Remove plugins that have been converted to modules #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliappis
approved these changes
Nov 17, 2022
b-deam
added a commit
to elastic/rally
that referenced
this pull request
Nov 21, 2022
Since 8.0, we've converted the repository-azure, repository-gcs and repository-s3 plugins into Elasticsearch modules, so that they are always included. Whilst adding or removing these plugins still succeeds, it is now a no-op. For now we still need to retain the existing post-install hooks (see elastic/rally-teams#76), so this is a first step in gracefully skipping any build steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we retain the respective plugin's directory and corresponding
plugin.pyfile, because although these are no longer 'plugins', we are still relying on the post-install hooks to configure the Elasticsearch keystore.See See elastic/rally#1622