Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the many-shards configurations to its own track #337

Open
DJRickyB opened this issue Oct 24, 2022 · 0 comments
Open

Split the many-shards configurations to its own track #337

DJRickyB opened this issue Oct 24, 2022 · 0 comments
Labels
new workload Any work related to adding a new track or functionality within a track tech debt

Comments

@DJRickyB
Copy link
Contributor

The Many Shards challenges in the elastic/logs tracks are beginning to bleed into the more core functionality of the track itself. It would be good to split these configurations to their own track for cleanliness' sake.
@DJRickyB DJRickyB added new workload Any work related to adding a new track or functionality within a track tech debt labels Oct 24, 2022
@DJRickyB DJRickyB mentioned this issue Oct 24, 2022
Merged
DJRickyB pushed a commit that referenced this issue Oct 24, 2022
make base_path static (#338)
7ce0858 

In #303 we added a safety net for running concurrent many shards snapshot challenges to the same bucket. Unfortunately the override applied for all base_path, including critically the non-many-shards challenges, rendering the base_path unconfigurable. I think we should still do this, but wait until #337 in order to do this as cleanly as possible.

This PR removes the base_path override by commenting with reference to the upstream issue we're dependent on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new workload Any work related to adding a new track or functionality within a track tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DJRickyB