Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set number of shards explicitly for all tracks #44

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we set the number of shards explicitly to the default
of five shards in order to keep results consistent.

Relates elastic/elasticsearch#30539

With this commit we set the number of shards explicitly to the default
of five shards in order to keep results consistent.

Relates elastic/elasticsearch#30539
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can move the number_of_shards defaults from noaa, nested and nyc_taxis to index.json in a separate PR, as discussed.

@danielmitterdorfer danielmitterdorfer merged commit 5badcb7 into elastic:master May 14, 2018
@danielmitterdorfer danielmitterdorfer deleted the explicit-shards branch May 14, 2018 13:34
@danielmitterdorfer
Copy link
Member Author

Thanks for the review! I'll create a separate PR for consistent handling of such index settings in other tracks as well.

danielmitterdorfer added a commit that referenced this pull request May 22, 2018
With this commit we set the number of shards explicitly to the default
of five shards in order to keep results consistent.

Relates elastic/elasticsearch#30539
Relates #44
danielmitterdorfer added a commit that referenced this pull request May 22, 2018
With this commit we set the number of shards explicitly to the default
of five shards in order to keep results consistent.

Relates elastic/elasticsearch#30539
Relates #44
danielmitterdorfer added a commit that referenced this pull request May 22, 2018
With this commit we set the number of shards explicitly to the default
of five shards in order to keep results consistent.

Relates elastic/elasticsearch#30539
Relates #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants