Skip to content

Commit

Permalink
Rename telemetry device that gathers GC stats
Browse files Browse the repository at this point in the history
With this commit we rename the internal telemetry device name that
gathers GC summary statistics from `NodeStats` to `GcTimesSummary` as
the latter name better conveys our intent.

Relates #475
  • Loading branch information
danielmitterdorfer authored Apr 20, 2018
1 parent 019dc5f commit 614d599
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion esrally/mechanic/launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def start(self):
t = telemetry.Telemetry(devices=[
telemetry.ClusterMetaDataInfo(es),
telemetry.ClusterEnvironmentInfo(es, self.metrics_store),
telemetry.NodeStats(es, self.metrics_store),
telemetry.GcTimesSummary(es, self.metrics_store),
telemetry.IndexStats(es, self.metrics_store),
telemetry.MlBucketProcessingTime(es, self.metrics_store)
])
Expand Down
4 changes: 2 additions & 2 deletions esrally/mechanic/telemetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -637,9 +637,9 @@ def add_node_stats(self, cluster, cluster_node, stats):
}


class NodeStats(InternalTelemetryDevice):
class GcTimesSummary(InternalTelemetryDevice):
"""
Gathers statistics via the Elasticsearch nodes stats API
Gathers a summary of the total young gen/old gen GC runtime during the whole race.
"""
def __init__(self, client, metrics_store):
super().__init__()
Expand Down
4 changes: 2 additions & 2 deletions tests/mechanic/telemetry_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ def test_enriches_cluster_nodes_for_elasticsearch_1_x(self):
self.assertEqual("unknown", n.fs[1]["spins"])


class NodeStatsTests(TestCase):
class GcTimesSummaryTests(TestCase):
@mock.patch("esrally.metrics.EsMetricsStore.put_value_cluster_level")
@mock.patch("esrally.metrics.EsMetricsStore.put_value_node_level")
def test_stores_only_diff_of_gc_times(self, metrics_store_node_level, metrics_store_cluster_level):
Expand Down Expand Up @@ -669,7 +669,7 @@ def test_stores_only_diff_of_gc_times(self, metrics_store_node_level, metrics_st
cfg = create_config()

metrics_store = metrics.EsMetricsStore(cfg)
device = telemetry.NodeStats(client, metrics_store)
device = telemetry.GcTimesSummary(client, metrics_store)
t = telemetry.Telemetry(cfg, devices=[device])
t.on_benchmark_start()
# now we'd need to change the node stats response
Expand Down

0 comments on commit 614d599

Please sign in to comment.