Refector and use a function

esrally/utils/process.py

@@ -179,14 +179,17 @@ def find_all_other_rally_processes() -> List[psutil.Process]:
     return others
 
 
+def redact_cmdline(cmdline: list) -> List[str]:
+    """
+    Redact client options in p.cmdline as it contains sensitive information like passwords
+    """
+
+    return ["=".join((value.split("=")[0], '"*****"')) if "--client-options" in value else value for value in cmdline]
+
+
 def kill_all(predicate: Callable[[psutil.Process], bool]) -> None:
     def kill(p: psutil.Process):
-        # Redact client options as it contains sensitive information like passwords
-        p_cmdline = p.cmdline()
-        for i, s in enumerate(p_cmdline):
-            if "--client-options" in s:
-                p_cmdline[i] = "=".join((s.split("=")[0], '"*****"'))
-        logging.getLogger(__name__).info("Killing lingering process with PID [%s] and command line [%s].", p.pid, p_cmdline)
+        logging.getLogger(__name__).info("Killing lingering process with PID [%s] and command line [%s].", p.pid, redact_cmdline(p.cmdline))
         p.kill()
         # wait until process has terminated, at most 3 seconds. Otherwise we might run into race conditions with actor system
         # sockets that are still open.