Skip to content

Commit

Permalink
Fix compare subcommand
Browse files Browse the repository at this point in the history
The refactoring in #1175 broken the compare subcommand due to reliance
on the `show-in-report` cli argument. As prior to the PR the subcommand
parsing logic was obscure the problem surfaced now.

This commit defaults the parameter `show-in-report` for the compare
subcommand to True. This parameter could be removed in the future,
the reason for adding it in the past was that some users relied on
parsing the report file and the comparison adds fields
(like percentiles) dynamically.
  • Loading branch information
dliappis committed Feb 19, 2021
1 parent 5679af3 commit ea296af
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion esrally/rally.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,10 @@ def add_track_source(subparser):
"--report-file",
help="Write the command line report also to the provided file.",
default="")

compare_parser.add_argument(
"--show-in-report",
help="Whether to include the comparison in the results file.",
default=True)
download_parser = subparsers.add_parser("download", help="Downloads an artifact")
download_parser.add_argument(
"--team-repository",
Expand Down

0 comments on commit ea296af

Please sign in to comment.