Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a sane default socket timeout #356

Closed
danielmitterdorfer opened this issue Nov 10, 2017 · 0 comments
Closed

Set a sane default socket timeout #356

danielmitterdorfer opened this issue Nov 10, 2017 · 0 comments
Labels
breaking Non-backwards compatible change bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Milestone

Comments

@danielmitterdorfer
Copy link
Member

The current socket timeout is (mistakenly) 60.000 seconds (almost 17 hours). Presumably, this was meant in milliseconds but the value really is denoted in seconds (see client docs).

Therefore, we will reduce the default socket timeout in Rally to the originally intended value of 60 seconds (the ES client's default value is 10 seconds). This should be sufficient for normal use cases. If users wish to change that value they can provide e.g. --client-options="timeout:120" to raise this value to 120 seconds in this example.

Marking as "breaking" as the reduction to 1 minute may break existing benchmarks (although it's unlikely).

@danielmitterdorfer danielmitterdorfer added :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. breaking Non-backwards compatible change bug Something's wrong labels Nov 10, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.8.0 milestone Nov 10, 2017
danielmitterdorfer added a commit that referenced this issue Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Development

No branches or pull requests

1 participant