Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rally-* index templates for ES 7.0 #605

Closed
danielmitterdorfer opened this issue Nov 26, 2018 · 2 comments · Fixed by #648
Closed

Update rally-* index templates for ES 7.0 #605

danielmitterdorfer opened this issue Nov 26, 2018 · 2 comments · Fixed by #648
Assignees
@ebadyano
Labels
enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Milestone
1.1.0

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Nov 26, 2018 •
edited
Loading

Rally defines default index templates for the index patterns rally-metrics-*, rally-races-* and rally-results-* in the resources directory of the source tree. When using an ES 6.x metrics store we get the following warnings:

Deprecated field [template] used, replaced by [index_patterns]

[_all] is deprecated in 6.0+ and will be removed in 7.0. As a replacement, you can use [copy_to] on mapping fields to create your own catch all field.

[_default_] mapping is deprecated since it is not useful anymore now that indexes cannot have more than one type

To be compatible with 7.0, we should change the mappings that Rally provides out of the box.

We should also switch the (sole) type for all indices to _doc as recommended in the Elasticsearch docs.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated labels Nov 26, 2018
@danielmitterdorfer danielmitterdorfer added this to the 1.x milestone Nov 26, 2018
@dliappis dliappis assigned dliappis and ebadyano and unassigned dliappis Jan 8, 2019
synhershko added a commit to synhershko/rally that referenced this issue Feb 16, 2019
@synhershko
Updates to support 7.x APIs
fe67cc4 
This fixes elastic#605
@synhershko synhershko mentioned this issue Feb 16, 2019
Merged
@synhershko
Copy link
Contributor

There you go: #648 :)

@ebadyano
Copy link
Contributor

Mapping got fixed in #648. I tested that changes work with older version ES 6.3.2. We need extra changes to metrics.py to be compatible with 7.0. @danielmitterdorfer is working on PR for that.

ebadyano pushed a commit that referenced this issue Feb 25, 2019
@synhershko @ebadyano
Updates to rally-* index templates to support 7.x APIs (#648)
cd9c0f2 
This fixes #605
ebadyano added a commit that referenced this issue Feb 25, 2019
@ebadyano
Update unit tests to reflect changes in #605
9af9a1c
@danielmitterdorfer danielmitterdorfer mentioned this issue Feb 26, 2019
Merged
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Feb 26, 2019
@danielmitterdorfer
Add compatibility layer for existing metrics store
e78f734 
With this commit we add a compatibility layer for existing metrics
stores that ensures Rally will not create incompatible mappings. Without
this change, Elasticsearch will complain that an existing metrics, races
or results index contains multiple types. By detecting this condition
upfront and instead writing to an index with the suffix `.new` we avoid
this condition. Note that when a new index is created (i.e. after a
month), it picks up the new mapping and is thus not prone to this issue.

Relates elastic#605
@danielmitterdorfer danielmitterdorfer mentioned this issue Feb 26, 2019
Merged
danielmitterdorfer added a commit that referenced this issue Feb 26, 2019
@danielmitterdorfer
Add compatibility layer for existing metrics store
ae9c599 
With this commit we add a compatibility layer for existing metrics
stores that ensures Rally will not create incompatible mappings. Without
this change, Elasticsearch will complain that an existing metrics, races
or results index contains multiple types. By detecting this condition
upfront and instead writing to an index with the suffix `.new` we avoid
this condition. Note that when a new index is created (i.e. after a
month), it picks up the new mapping and is thus not prone to this issue.

Relates #605 
Relates #655
@danielmitterdorfer danielmitterdorfer modified the milestones: 2.x, 1.1.0 May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebadyano ebadyano

Labels
enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Updates to support 7.x APIs synhershko/rally
4 participants
@synhershko @danielmitterdorfer @dliappis @ebadyano