Allow to downsample request metrics #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we introduce a new setting `metrics.request.downsample.factor` that allows to control that only every N-th request metric sample is recorded in the metrics store (this does not affect throughput calculation which will still consider every sample). This allows to reduce the number of samples which can be useful when benchmarks are run with many hundreds or thousands of clients which would produce a very high number of samples.
danielmitterdorfer
added
enhancement
|
Note that there are no docs for this; this will be documented once we have a config reference docs page (#991). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we introduce a new setting
metrics.request.downsample.factorthat allows to control that onlyevery N-th request metric sample is recorded in the metrics store (this
does not affect throughput calculation which will still consider every
sample). This allows to reduce the number of samples which can be useful
when benchmarks are run with many hundreds or thousands of clients which
would produce a very high number of samples.