Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for trailing comma tuple #1038

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Check for trailing comma tuple #1038

merged 1 commit into from
Aug 3, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we enable the linter error for trailing comma tuples
and fix all existing issues.

Relates #838

@danielmitterdorfer
Check for trailing comma tuple
b44000d 
With this commit we enable the linter error for trailing comma tuples
and fix all existing issues.

Relates elastic#838
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jul 28, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.1 milestone Jul 28, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Jul 28, 2020
@dliappis dliappis mentioned this pull request Jul 28, 2020
Closed
46 tasks
hub-cap
hub-cap approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has bitten me so hard in the past,

LGTM cc @dliappis who it has also bitten,

@danielmitterdorfer danielmitterdorfer merged commit 6b21d7b into elastic:master Aug 3, 2020
@danielmitterdorfer danielmitterdorfer deleted the lint-trailing-comma branch August 3, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hub-cap hub-cap hub-cap approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @hub-cap