Check for pointless statements #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we enable the linter error for pointless statements and fix all existing issues. Relates elastic#838
danielmitterdorfer
added
enhancement
46 tasks
hub-cap
approved these changes
Jul 30, 2020
| """ | ||
| Return parsed comma separated host string as dict with "default" key. | ||
| This is needed to support backwards compatible --target-hosts for single clusters that are not | ||
| defined as a json string or file. | ||
| """ | ||
|
|
||
| from elasticsearch.client import _normalize_hosts |
There was a problem hiding this comment.
now im curious, why is this here and not at the top?
There was a problem hiding this comment.
It is related to initialization of loggers. We noticed that especially the elasticsearch dependency is problematic in that respect. A long time ago we had all imports at the top but the elasticsearch loggers were initialized when a module was loaded that imported elasticsearch which happened before Rally had a chance to configure logging properly. Therefore we never import any elasticsearch module at the top in Rally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we enable the linter error for pointless statements and
fix all existing issues.
Relates #838