Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify corpus meta-data #1065

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Allow to specify corpus meta-data #1065

merged 3 commits into from
Oct 27, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we add a new property meta to the corpus property
and its nested documents. This allows users to specify arbitrary
additional meta-data that can e.g. be used by custom runners.

@danielmitterdorfer
Allow to specify corpus meta-data
e70688a 
With this commit we add a new property `meta` to the `corpus` property
and its nested documents. This allows users to specify arbitrary
additional meta-data that can e.g. be used by custom runners.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like labels Sep 29, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.2 milestone Sep 29, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Sep 29, 2020
gingerwizard
gingerwizard approved these changes Oct 5, 2020
View reviewed changes
Copy link

@gingerwizard gingerwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this it will be allow us to centralize alot of custom config duplicated amongst operators. Maybe the docs could illustrate this is its primary purpose?

@danielmitterdorfer danielmitterdorfer modified the milestones: 2.0.2, 2.0.3 Oct 26, 2020
@danielmitterdorfer danielmitterdorfer merged commit 435e185 into elastic:master Oct 27, 2020
@danielmitterdorfer danielmitterdorfer deleted the corpus-meta-data branch October 27, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gingerwizard gingerwizard gingerwizard approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @gingerwizard