Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix punctuation #1145

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Fix punctuation #1145

merged 2 commits into from
Jan 11, 2021

Conversation

glenacota
Copy link
Contributor

Changes in this pull request mainly enforce consistency in lists punctuation - i.e., end sentences with a period. Other changes fix punctuation typos.

@dliappis dliappis requested a review from DJRickyB January 11, 2021 13:35
@dliappis dliappis added :Docs Changes to the documentation cleanup Linter changes, reformatting, removal of unused code etc. labels Jan 11, 2021
@dliappis dliappis added this to the 2.0.3 milestone Jan 11, 2021
Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glenacota Thank you so much for the PR! Left one ask so far

docs/track.rst Show resolved Hide resolved
docs/track.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Very timely as we are just about to push a new release (including for our docs), much appreciated

@DJRickyB DJRickyB merged commit 8d4004f into elastic:master Jan 11, 2021
@glenacota
Copy link
Contributor Author

thanks for your amazing job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. :Docs Changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants