Log trace of uncaught exception in load generator #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we enhance the handlers for uncaught exception handlers in the load generator to log the full exception trace before forwarding the exception *message* to the coordinating process. Previously, the coordinating process would then log the exception message but we lost the actual trace which makes diagnosis harder.
danielmitterdorfer
added
enhancement
|
@elasticmachine test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we enhance the handlers for uncaught exceptions
in the load generator to log the full exception trace before forwarding
the exception message to the coordinating process. Previously, the
coordinating process would then log the exception message but we lost
the actual trace which makes diagnosis harder.