Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop relative-time metric #1231

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we drop the metric relative-time which contained a
timestamp in microseconds relative to the start of a task. It is
superseeded by the metric relative-time-ms which has been introduced
for a transition period between Rally 2.1.0 and Rally 2.3.0. With Rally
2.4.0 we will align all time-related metrics to be denoted in
milliseconds.

Relates #1198

With this commit we drop the metric `relative-time` which contained a
timestamp in microseconds relative to the start of a task. It is
superseeded by the metric `relative-time-ms` which has been introduced
for a transition period between Rally 2.1.0 and Rally 2.3.0. With Rally
2.4.0 we will align all time-related metrics to be denoted in
milliseconds.

Relates elastic#1198
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated breaking Non-backwards compatible change labels Apr 6, 2021
@danielmitterdorfer danielmitterdorfer added this to the 2.2.0 milestone Apr 6, 2021
@danielmitterdorfer danielmitterdorfer self-assigned this Apr 6, 2021
@danielmitterdorfer
Copy link
Member Author

While this change can already be reviewed I intend to target this for the 2.2.0 release (i.e. not into any patch releases in the 2.1 series that we might release meanwhile).

Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@danielmitterdorfer danielmitterdorfer merged commit e7a20e7 into elastic:master Apr 12, 2021
@danielmitterdorfer danielmitterdorfer deleted the drop-relative-time branch April 12, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants