-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for numbers alignment in table output (#1202) #1236
Conversation
previously numbers alignment was hardcoded to 'right'. This change adds the ability to set a configuration value 'numbers.align' in the formatting section of the config to alter the format of the table output. Signed-off-by: cmanning09 <cmanning09@users.noreply.github.com>
Thanks for your interest in Rally and your PR! We'll start the review process shortly. @elasticmachine test this please |
Hi! Thank you for this. For the
From the log:
|
Good catch. I have addressed the issue you raised. Please let me know if there is anything else. |
wonderful! thank you @cmanning09. This code functions as I'd expect, and as you indicated in the initial commit it addresses #1202 nicely. I have one more ask/iteration of you: this functionality should be documented. please consider whether it will be supported similarly to the Thank you! |
I addressed your concern by adding support through CLI flags for both race and compare subcommands. Is there anything else? |
Beautiful! I've tested it and it works as expected. Please add the documentation and then I think we're all set. (Should be in docs/command_line_reference.rst) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@elasticmachine run tests |
@cmanning09, just as an update: I am having trouble getting this branch to pass our internal CI. I don't believe this is due to your code, so please bear with me. Once tests pass cleanly I will merge this one in |
@elasticmachine update branch |
@elasticmachine run tests |
previously numbers alignment was hardcoded to 'right'. This change adds
the ability to set a configuration value 'numbers.align' in the
formatting section of the config to alter the format of the table output.