Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ephemeral ports in integration tests #1244

Merged

Conversation

danielmitterdorfer
Copy link
Member

Previously, some integration tests have spun up clusters in the
ephemeral port range (on Linux this port range usually starts with port
32768) which can negatively influence test stability. With this commit
we bind test clusters in integration tests to ports below the ephemeral
port range to avoid this issue.

Previously, some integration tests have spun up clusters in the
ephemeral port range (on Linux this port range usually starts with port
32768) which can negatively influence test stability. With this commit
we bind test clusters in integration tests to ports below the ephemeral
port range to avoid this issue.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Apr 20, 2021
@danielmitterdorfer danielmitterdorfer added this to the 2.2.0 milestone Apr 20, 2021
@danielmitterdorfer danielmitterdorfer self-assigned this Apr 20, 2021
Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit 32508a2 into elastic:master Apr 20, 2021
@danielmitterdorfer danielmitterdorfer deleted the avoid-ephemeral-ports branch April 20, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants