Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor change to docs #1433

Merged
merged 1 commit into from
Feb 11, 2022
Merged

minor change to docs #1433

merged 1 commit into from
Feb 11, 2022

Conversation

DJRickyB
Copy link
Contributor

No description provided.

@DJRickyB DJRickyB added :Docs Changes to the documentation :internal Changes for internal, undocumented features: e.g. experimental, release scripts labels Feb 11, 2022
@DJRickyB DJRickyB added this to the 2.4.0 milestone Feb 11, 2022
@DJRickyB DJRickyB requested a review from inqueue February 11, 2022 20:36
@DJRickyB DJRickyB self-assigned this Feb 11, 2022
inqueue
inqueue approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@inqueue inqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right change to clarify bulk action_and_meta_data is to not be included in the corpora document count when it is included in the documents file. LGTM

@DJRickyB DJRickyB merged commit cb14f9b into master Feb 11, 2022
@DJRickyB DJRickyB deleted the DJRickyB-patch-1 branch February 11, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inqueue inqueue inqueue approved these changes

Assignees

@DJRickyB DJRickyB

Labels
:Docs Changes to the documentation :internal Changes for internal, undocumented features: e.g. experimental, release scripts
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DJRickyB @inqueue