Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce field-caps operation-type #1471

Merged
merged 13 commits into from
Apr 20, 2022
Merged

Introduce field-caps operation-type #1471

merged 13 commits into from
Apr 20, 2022

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 1, 2022

@dnhatn dnhatn added the enhancement Improves the status quo label Apr 1, 2022
pquentin
pquentin requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's a great start.

docs/track.rst Outdated Show resolved Hide resolved
docs/track.rst Outdated Show resolved Hide resolved
docs/track.rst Outdated Show resolved Hide resolved
docs/track.rst Outdated Show resolved Hide resolved
esrally/driver/runner.py Show resolved Hide resolved
dnhatn and others added 5 commits April 13, 2022 13:54
@dnhatn
make field-caps a composite operation
5229307
@dnhatn @pquentin
Update docs/track.rst
d82c2d1 
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
@dnhatn @pquentin
Update docs/track.rst
b3d7b6c 
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
@dnhatn @pquentin
Update docs/track.rst
bf1600c 
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
@dnhatn @pquentin
Update docs/track.rst
e63287d 
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
@dnhatn
Copy link
Member Author

dnhatn commented Apr 13, 2022

@pquentin Thank you for your review. I've applied your suggestions. I also pushed 5229307 to make the field-caps a composite runner as we will use field-caps and search requests together in tracks.

@dnhatn dnhatn requested a review from pquentin April 13, 2022 18:00
pquentin
pquentin approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@pquentin pquentin added this to the 2.5.0 milestone Apr 20, 2022
@dnhatn
Copy link
Member Author

dnhatn commented Apr 20, 2022

@pquentin Thank you for reviewing :).

@dnhatn dnhatn merged commit fcde84d into elastic:master Apr 20, 2022
@dnhatn dnhatn deleted the field_caps_op_type branch April 20, 2022 12:29
@pquentin pquentin added highlight A substantial improvement that is worth mentioning separately in release notes and removed enhancement Improves the status quo labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
highlight A substantial improvement that is worth mentioning separately in release notes
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dnhatn @pquentin