Retry incomplete HTTP downloads #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when did not download enough data, we just abort the benchmark. Instead, ask urllib3 to retry it per our retry policy. This does not change the existing Rally logic around Content-Length as it's possible to specify the expected length and I don't want this fix to change other behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we did not download enough data, we just abort the
benchmark. Instead, let's ask urllib3 to retry it per our retry policy.
This does not change the existing Rally logic around Content-Length as
it's possible to specify the expected length and I don't want this fix
to change other behavior.
Closes #1504 (it was a good first issue but we hit this a lot recently)