Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention that create/restore-snapshot is an administrative operation #1572

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Mention that create/restore-snapshot is an administrative operation #1572

merged 2 commits into from
Sep 5, 2022

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Sep 5, 2022 •
edited
Loading

Docs are currently missing that create/restore-snapshot are administrative operations.

@dliappis dliappis added enhancement Improves the status quo :Docs Changes to the documentation labels Sep 5, 2022
@dliappis dliappis requested a review from pquentin September 5, 2022 11:45
@dliappis dliappis self-assigned this Sep 5, 2022
pquentin
pquentin requested changes Sep 5, 2022
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great catch! I checked all snapshot operations, and restore-snapshot is also an administrative operation that is not reported as such. Can you please include it too?

@dliappis dliappis changed the title [docs] Mention that create-snapshot is an administrative operation [docs] Mention that create|restore-snapshot is an administrative operation Sep 5, 2022
@dliappis dliappis changed the title [docs] Mention that create|restore-snapshot is an administrative operation [docs] Mention that create/restore-snapshot is an administrative operation Sep 5, 2022
@dliappis
Copy link
Contributor Author

dliappis commented Sep 5, 2022

Thanks, great catch! I checked all snapshot operations, and restore-snapshot is also an administrative operation that is not reported as such. Can you please include it too?

Thanks for checking. Added it in b13679b and adjusted PR description.

pquentin
pquentin approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@dliappis dliappis merged commit 254f54b into elastic:master Sep 5, 2022
@pquentin pquentin added this to the 2.7.0 milestone Nov 2, 2022
@pquentin pquentin changed the title [docs] Mention that create/restore-snapshot is an administrative operation Mention that create/restore-snapshot is an administrative operation Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees

@dliappis dliappis

Labels
:Docs Changes to the documentation enhancement Improves the status quo
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dliappis @pquentin