Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer ssl parameter in aiohttp client API #1611

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Nov 4, 2022

Using ssl= is the preferred way since 3.0 (aio-libs/aiohttp#2626) and ssl_context= goes away in the next version, 4.0 (aio-libs/aiohttp#3548).

This was noticed by @michaelbaamonde in https://github.com/elastic/rally/pull/1510/files/9627d291895ac90f7ae99143f2567f8d8cd1209c#r891133343.

Using ssl= is the preferred way since 3.0 (aio-libs/aiohttp#2626) and
ssl_context= goes away in the next version, 4.0 (aio-libs/aiohttp#3548).
@pquentin pquentin added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. tech debt labels Nov 4, 2022
@pquentin pquentin added this to the 2.7.1 milestone Nov 4, 2022
@pquentin pquentin self-assigned this Nov 4, 2022
@pquentin
Copy link
Member Author

pquentin commented Nov 4, 2022

Got the following error but no additional logs:

esrally.exceptions.SystemSetupError: Docker container [esrally-source-builder] failed with status code [1]: Error [None]   

@elasticmachine run rally/it-python38 please

Copy link
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. CI failures look unrelated, not sure what's up.

@pquentin
Copy link
Member Author

pquentin commented Nov 9, 2022

@elasticmachine update branch please

@pquentin pquentin merged commit 0f848c7 into elastic:master Nov 9, 2022
@pquentin pquentin deleted the aiohttp-ssl branch November 9, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:misc Changes that don't affect users directly: linter fixes, test improvements, etc. tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants