Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying --installation-id in esrally install #1649

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Allow specifying --installation-id in esrally install #1649

merged 1 commit into from
Jan 9, 2023

Conversation

b-deam
Copy link
Member

@b-deam b-deam commented Jan 5, 2023

With this commit we allow users to specify a custom installation id when
invoking the install subcommand, allowing us to control the directory
artifacts are installed into.

Example:

$ esrally install --quiet  --installation-id testing --distribution-version=8.5.2 --node-name="rally-node-0" --network-host="127.0.0.1" --http-port=39200 --master-nodes="rally-node-0" --seed-hosts="127.0.0.1:39300" 
{
  "installation-id": "testing"
}
$ ls ~/.rally/benchmarks/races/testing 
node-config.json  rally-node-0/

@b-deam b-deam added enhancement Improves the status quo :Usability Makes Rally easier to use :Config Config file format changes, new properties, ... labels Jan 5, 2023
@b-deam b-deam added this to the 2.7.1 milestone Jan 5, 2023
@b-deam b-deam self-assigned this Jan 5, 2023
michaelbaamonde
michaelbaamonde approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is useful. LGTM.

@b-deam b-deam merged commit 11145b1 into elastic:master Jan 9, 2023
@pquentin pquentin changed the title Allow specifying installation id Allow specifying --installation-id in esrally install Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbaamonde michaelbaamonde michaelbaamonde approved these changes

@dliappis dliappis Awaiting requested review from dliappis

Assignees

@b-deam b-deam

Labels
:Config Config file format changes, new properties, ... enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Milestone
2.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@b-deam @michaelbaamonde