Add role metadata to node-stats telemetry device #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-deam
added
enhancement
|
@elasticmachine run rally/it-python38 |
pquentin
approved these changes
Jan 18, 2023
@elasticmachine run rally/it-python310 |
pquentin
reviewed
Jan 18, 2023
esrally/actor.py
Outdated
| @@ -259,6 +259,7 @@ def bootstrap_actor_system(try_join=False, prefer_local_only=False, local_ip=Non | |||
| if coordinator_ip: | |||
| # Make the coordinator node the convention leader | |||
| capabilities["Convention Address.IPv4"] = "%s:1900" % coordinator_ip | |||
| print(system_base, capabilities) | |||
|
I raised #1655 to track the CI failure, since it's not the first time we've seen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to know what roles a node was configured for when analysing metrics in a remote metrics store.
For example:
I've tested this with a local 8.5 metrics store:
esrally race --track=geopoint --pipeline=benchmark-only --target-hosts=https://localhost:9222 --challenge=append-fast-with-conflicts --telemetry=node-stats --client-options="timeout:180,verify_certs:false,basic_auth_user:'elastic',basic_auth_password:'changeme'" --kill-running-processes --test-mode