Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct params for create component template #1690

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

danielmitterdorfer
Copy link
Member

The Elasticsearch Python client does not accept a request body but rather requires parts of the body to be passed for the create component template API call. With this commit we adapt Rally to these changes.

The Elasticsearch Python client does not accept a request body but
rather requires parts of the body to be passed for the create component
template API call. With this commit we adapt Rally to these changes.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. labels Mar 24, 2023
@danielmitterdorfer danielmitterdorfer added this to the 2.8.0 milestone Mar 24, 2023
@danielmitterdorfer danielmitterdorfer self-assigned this Mar 24, 2023
Copy link
Member

@b-deam b-deam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. LGTM.

@b-deam
Copy link
Member

b-deam commented Mar 27, 2023

Hmm, something's up with esrally install --quiet --http-port=19200 --node=rally-node --master-nodes=rally-node --car=4gheap,trial-license,x-pack-ml --seed-hosts="127.0.0.1:19300" --revision=current as part of rally-tracks-compat.

I can't repro this locally, so I suspect something is up with GH Actions since GitHub updated their SSH key on Friday. The blog post mentions:

GitHub Actions users may see failed workflow runs if they are using actions/checkout with the ssh-key option. We are updating the actions/checkout action in all our supported tags, including @v2, @V3, and @main. If you pin the action to a commit SHA and use the ssh-key option, you’ll need to update your workflow. You can read more about this process in our official documentation for Actions security hardening.

As far as I can tell, we don't use the ssh-key option, and my GH Actions-fu is non existent. @pquentin can you help here?

@b-deam
Copy link
Member

b-deam commented Mar 27, 2023

I see now that CI failing is related to this #1688

@pquentin agreed to take a look tomorrow.

@danielmitterdorfer danielmitterdorfer merged commit f3f4865 into elastic:master Mar 29, 2023
@danielmitterdorfer danielmitterdorfer deleted the fix-comp-templ branch March 29, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants