Measure time until last response chunk #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rally uses timers internally to measure when a request started and when it has completed. However, it has stopped measuring as soon as the first byte of the response has been received instead of waiting for the full response. This can skew service time measurement if the response is large and Elasticsearch streams it. With this commit we wait until the last chunk of the response has been received. This results in a more realistic service time metric in these cases. Closes elastic#1822
danielmitterdorfer
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rally uses timers internally to measure when a request started and when it has completed. However, it has stopped measuring as soon as the first byte of the response has been received instead of waiting for the full response. This can skew service time measurement if the response is large and Elasticsearch streams it.
With this commit we wait until the last chunk of the response has been received. This results in a more realistic service time metric in these cases.
Closes #1822