Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build multi-arch Docker image #1878

Closed
wants to merge 10 commits into from
Closed

Build multi-arch Docker image #1878

wants to merge 10 commits into from

Conversation

pquentin
Copy link
Member

This pull request builds on top of #187. It adds multi-arch builds as done in Eland nearly one year ago: elastic/eland#615. The main difference is that in Rally we test the image before pushing it. However, this workflow is not supported for multi-arch images: docker/buildx#59. As a workaround, we build a linux/amd64 image first, test it, and then build and push the actual multi-arch image with linux/amd64 and linux/arm64. While it is named linux/arm64, it's supported natively on Apple silicon hardware, such as M1/M2/M3 MacBooks.

To review this, the only relevant commit is 515ce21. I believe this should only be merged after #1871, because it's a different concern, and may need to be reverted independently.

favilo and others added 10 commits September 16, 2024 09:38
Running the docker image with a mounted `/rally/.rally` directory that
already contains the configuration file didn't work. So I had to change
how we parse the logging config and rally.ini files.

Now we dealy the parsing of the environment variables to read time, to
make running from docker and outside of docker compatible with each
other.
I'd been installing `esrally` to the wrong location, now it's correctly
in venv/bin
@pquentin pquentin added enhancement Improves the status quo :Packaging Installation issues or packaging problems labels Sep 24, 2024
@favilo
Copy link
Contributor

favilo commented Sep 24, 2024

Hah, I've also been working on #1873

That one tests both architectures, and uses buildkite runners of each architecture in parallel. Followed by a manifest command to merge them

I also wanted to have a dev-latest tag for daily dev builds between official releases

@pquentin
Copy link
Member Author

Excellent! Closing in favor of #1873.

@pquentin pquentin closed this Sep 24, 2024
@pquentin pquentin deleted the docker-multiarch branch September 24, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Packaging Installation issues or packaging problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants