Allow to pass parameters via a file #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we allowed users to pass track, car and plugin parameters via a list of key-value pairs. While this covers a lot of use cases, we can give users even more flexibility by letting them provide a file to Rally. This allows users to pass also nested structures which is e.g. handy to specify index settings.
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Mar 15, 2018
esrally/rally.py
Outdated
| @@ -587,6 +587,15 @@ def dispatch_sub_command(cfg, sub_command): | |||
| return False | |||
|
|
|||
|
|
|||
| def to_dict(arg): | |||
| if io.has_extension(arg, ".json"): | |||
| import json | |||
There was a problem hiding this comment.
Minor comment: you probably have your reasons, but why not have this at the top? AFAIK pep8 is rather strict about this. I read some literature preferring from json import load for inside-function uses such as this one, if it must be done.
There was a problem hiding this comment.
I wanted to limit the scope of the import so we don't accidentally use this functionality somewhere else. I'm fine with putting it at the top. Mid-term it might make sense to split rally.py though.
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 15, 2018
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 15, 2018
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 15, 2018
danielmitterdorfer
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 15, 2018
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we allowed users to pass track, car and plugin parameters via
a list of key-value pairs. While this covers a lot of use cases, we can
give users even more flexibility by letting them provide a file to
Rally. This allows users to pass also nested structures which is e.g.
handy to specify index settings.