Remove automatic index management #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we remove the ability that Rally automatically deletes and creates indices and users need to add explicit tasks now to their tracks in order to make this work. The rationale behind all this work is that we want the core of Rally to be agnostic to the tasks that it executes. Closes elastic#380
danielmitterdorfer
added
enhancement
|
This should be reviewed together with elastic/rally-tracks#41 (the change in rally-tracks is compatible with older versions of Rally so the track changes will be merged first). |
dliappis
approved these changes
Apr 5, 2018
| MAXIMUM_SUPPORTED_TRACK_VERSION = 2 | ||
| """ | ||
| Creates a track from a track file. | ||
| """ | ||
|
|
||
| def __init__(self, cfg): | ||
| track_schema_file = "%s/resources/track-schema.json" % (cfg.opts("node", "rally.root")) | ||
| track_schema_file = os.path.join(cfg.opts("node", "rally.root"), "resources", "track-schema.json") |
There was a problem hiding this comment.
👍 one more step towards platform independence 😆
| @@ -679,7 +679,7 @@ def test_post_processes_track_spec(self): | |||
| "operations": [ | |||
| { | |||
| "name": "index-append", | |||
| "operation-type": "index", | |||
| "operation-type": "bulk", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we remove the ability that Rally automatically deletes
and creates indices and users need to add explicit tasks now to their
tracks in order to make this work.
The rationale behind all this work is that we want the core of Rally to
be agnostic to the tasks that it executes.
Closes #380