Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align operation param names with runners #469

Merged
merged 4 commits into from
Apr 16, 2018

Conversation

danielmitterdorfer
Copy link
Member

With this commit we use the same operation parameter names in the track as in
the runner implementations. We also introduce a backwards-compatibility layer,
so old names are still recognized but issue a deprecation warning.

Closes #379

With this commit we change the parameter "master_timeout" to
"master-timeout" aligning it with the convention of using hyphenated
names. As this parameter is undocumented, we just change it without
introducing any backwards-compatibility.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like labels Apr 12, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.10.0 milestone Apr 12, 2018
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for consistency! LGTM

@danielmitterdorfer danielmitterdorfer merged commit 9c3917f into elastic:master Apr 16, 2018
@danielmitterdorfer danielmitterdorfer deleted the align-params branch April 20, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants