Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record_process_stats() for process.* stats #497

Merged

Conversation

paulcoghlan
Copy link
Contributor

This PR adds the Elasticsearch node process stats (https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html#process-statsnode-stats-include-process) so that CPU metrics can be recorded when running in pipeline=benchmark-only mode.

There is a new node-stats-include-process telemetry parameter flag to control whether these stats are collected (defaults to true).

@paulcoghlan paulcoghlan added enhancement Improves the status quo :Telemetry Telemetry Devices that gather additional metrics labels May 11, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.12.0 milestone May 14, 2018
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @paulcoghlan! LGTM

@dliappis
Copy link
Contributor

Thanks @paulcoghlan !

@danielmitterdorfer danielmitterdorfer merged commit 8cbe707 into elastic:master May 14, 2018
@paulcoghlan paulcoghlan deleted the paulcoghlan-process-stats branch May 14, 2018 09:27
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.12.0, 1.0.0 May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Telemetry Telemetry Devices that gather additional metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants