Exponential back-off for retrying transport errors to metrics store #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce exponential back-off mechanism for waiting between retries when TransportErrors occurs towards the metrics store. Increase amount of execution attempts to 11 (10 retries) so that total time spent in retries is 17.05min.
dliappis
added
enhancement
esrally/metrics.py
Outdated
| execution_count = 0 | ||
|
|
||
| while execution_count < max_execution_count: | ||
| time_to_sleep = 2 ** execution_count + (random.randint(0, 1000) / 1000) |
There was a problem hiding this comment.
Any reason you use random.randint(0, 1000) / 1000 instead of just random.random()?
There was a problem hiding this comment.
Might also be worth adding a debug log statement?
There was a problem hiding this comment.
D'oh was thinking too much in milliseconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce exponential back-off mechanism for waiting between retries
when TransportErrors occurs towards the metrics store. Increase
amount of execution attempts to 11 (10 retries) so that total time
spent in retries is 17.05min.
Closes #548