Improve compatibility when loading invalid JSON #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we caught `JSONDecodeError` in the error handler when loading JSON. However, this class has been introduced in Python 3.5 and thus we fail with a confusing error message: ``` AttributeError: 'module' object has no attribute 'JSONDecodeError' ``` To avoid this situation, we broaden the `except` clause and also introduce a new test case to ensure error handling works correctly on all supported Python versions. Closes elastic#564
danielmitterdorfer
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we caught
JSONDecodeErrorin the error handler when loadingJSON. However, this class has been introduced in Python 3.5 and thus we
fail on Python 3.4 with a confusing error message:
To avoid this situation, we broaden the
exceptclause and alsointroduce a new test case to ensure error handling works correctly on
all supported Python versions.
Closes #564