Change logging level for esrally command line to DEBUG #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All command line arguments were logged in a generic fashion and among them can be passwords. We want to avoid the passwords being logged by default if they are provided but still keep the ability to configure the command line arguments to get logged if necessary.
danielmitterdorfer
approved these changes
Nov 27, 2018
dliappis
approved these changes
Nov 27, 2018
ebadyano
added
the
:misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All command line arguments were logged in a generic fashion and among
them can be passwords. We want to avoid the passwords being logged by
default if they are provided but still keep the ability to configure
the command line arguments to get logged if necessary.