Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typo #621

Merged
merged 3 commits into from
Jan 4, 2019
Merged

Minor typo #621

merged 3 commits into from
Jan 4, 2019

Conversation

geekpete
Copy link
Member

@geekpete geekpete commented Jan 3, 2019

No description provided.

@danielmitterdorfer
Copy link
Member

Thanks for the PR. git grep "Totally written" shows a few more places that need to be fixed though. Would you mind updating them as well?

@danielmitterdorfer danielmitterdorfer self-requested a review January 3, 2019 12:28
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Docs Changes to the documentation labels Jan 3, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.0.3 milestone Jan 3, 2019
@geekpete
Copy link
Member Author

geekpete commented Jan 4, 2019

Fixed a bunch of other mentions of the same typo and also had to adjust indent.
Should be good to go, let me know if this looks ok to squash and merge.

Thanks.

danielmitterdorfer
danielmitterdorfer approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating @geekpete. LGTM. You can merge anytime.

@geekpete geekpete merged commit 9788246 into master Jan 4, 2019
@danielmitterdorfer danielmitterdorfer deleted the geekpete-patch-1 branch March 5, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
:Docs Changes to the documentation enhancement Improves the status quo
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@geekpete @danielmitterdorfer