Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override request timeout for force-merge #669

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we add the ability to override the global request
timeout for the force-merge operation. This relates to #567 but at the
moment we only implement it for force-merge and due to the fact that
we cannot solve this in a generic fashion for that operation anyway we
the current implementation is likely to stay even when we implement
full support in #567. We intentionally add this new parameter without
documentation so we are free to change the parameter name later on.

Relates #567

With this commit we add the ability to override the global request
timeout for the `force-merge` operation. This relates to elastic#567 but at the
moment we only implement it for `force-merge` and due to the fact that
we cannot solve this in a generic fashion for that operation anyway we
the current implementation is likely to stay even when we implement
full support in elastic#567. We intentionally add this new parameter without
documentation so we are free to change the parameter name later on.

Relates elastic#567
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. labels Mar 19, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.1.0 milestone Mar 19, 2019
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit 98bfa0b into elastic:master Mar 19, 2019
@danielmitterdorfer
Copy link
Member Author

Thanks for the review!

@danielmitterdorfer danielmitterdorfer deleted the force-merge-timeout branch March 19, 2019 10:15
danielmitterdorfer added a commit that referenced this pull request Mar 19, 2019
With this commit we pass the request timeout via the generic `params`
dictionary to the optimize API (which we call via the client's raw
transport API) instead of as a dedicated kw parameter (which is plain
wrong).

Relates #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants