Add ability to download from S3 buckets #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add the ability to download from S3 buckets. A download URL must start with the scheme `s3://` to be recognized as S3 bucket. Provided that S3 access is properly configured Rally can also handle downloads from private S3 buckets.
danielmitterdorfer
added
enhancement
ebadyano
reviewed
Mar 29, 2019
| return expected_size_in_bytes | ||
|
|
||
|
|
||
| def download_http(url, local_path, expected_size_in_bytes=None, progress_indicator=None): |
There was a problem hiding this comment.
does it also make sense to add a unit test for download_http? I couldn't find if we have a test for download().. although it is a well executed code path so not sure if we need it.
There was a problem hiding this comment.
Tbh, I attempted to do it but I ended up mocking so much code that I had the impression it's not really worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add the ability to download from S3 buckets. A
download URL must start with the scheme
s3://to be recognized as S3bucket. Provided that S3 access is properly configured Rally can also
handle downloads from private S3 buckets.