Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pip for virtualenv #707

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we upgrade pip to the latest version in the make install target (used only for development). This avoids warnings about
an outdated version and let's us also use newer pip features in the
future.

With this commit we upgrade pip to the latest version in the `make
install` target (used only for development). This avoids warnings about
an outdated version and let's us also use newer pip features in the
future.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jun 7, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.2.0 milestone Jun 7, 2019
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to use tab for the indentation.

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielmitterdorfer
Copy link
Member Author

Thanks for the review! :)

@danielmitterdorfer danielmitterdorfer merged commit c7030ff into elastic:master Jun 7, 2019
@danielmitterdorfer danielmitterdorfer deleted the upgrade-pip branch June 7, 2019 10:17
@dliappis dliappis modified the milestones: 1.2.0, 1.2.1 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants