Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass request_cache by default #710

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Don't pass request_cache by default #710

merged 1 commit into from
Jun 13, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit Rally will only pass the request_cache query
parameter to Elasticsearch iff the cache property is defined in the
track. Otherwise, it will adhere to the default that has been specified
in the index settings.

Closes #596

@danielmitterdorfer
Don't pass request_cache by default
ac71180 
With this commit Rally will only pass the `request_cache` query
parameter to Elasticsearch iff the `cache` property is defined in the
track. Otherwise, it will adhere to the default that has been specified
in the index settings.

Closes elastic#596
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. breaking Non-backwards compatible change labels Jun 7, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.2.0 milestone Jun 7, 2019
@danielmitterdorfer
Copy link
Member Author

I've marked this change as breaking as Rally will behave differently now in case cache is not specified in the track. To ensure that the standard benchmark suite still behaves the same, this requires elastic/rally-tracks#78 to be merged (and backported) first.

ebadyano
ebadyano approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you!

drawlerr
drawlerr approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@drawlerr drawlerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@danielmitterdorfer
Copy link
Member Author

Thanks for your reviews! :)

@danielmitterdorfer danielmitterdorfer merged commit 659ef10 into elastic:master Jun 13, 2019
@danielmitterdorfer danielmitterdorfer deleted the empty-request-cache-default branch June 13, 2019 06:40
@dliappis dliappis modified the milestones: 1.2.0, 1.2.1 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadyano ebadyano ebadyano approved these changes

@drawlerr drawlerr drawlerr approved these changes

Assignees
No one assigned
Labels
breaking Non-backwards compatible change bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

Search request_cache set to false by default
4 participants
@danielmitterdorfer @drawlerr @ebadyano @dliappis