Be resilient upon startup #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we make Rally more resilient when it is not able to determine some information upon startup of the cluster.
danielmitterdorfer
added
enhancement
dliappis
reviewed
Jul 16, 2019
| # noinspection PyBroadException | ||
| try: | ||
| distribution_version = es.info()["version"]["number"] | ||
| except BaseException: |
There was a problem hiding this comment.
Do we need such a broad exception here? I thought (ReadTimeoutError, ConnectionTimeout, AuthorizationException, ConnectionError) is sufficient?
There was a problem hiding this comment.
We don't but I wanted to avoid importing the elasticsearch module just for that.
|
|
||
| def wrap(it): |
There was a problem hiding this comment.
Addressed in 3cfa545. Not sure why my IDE didn't show it earlier...
| def wrap(it): | ||
| return it if callable(it) else ResponseSupplier(it) | ||
|
|
||
| class ResponseSupplier: |
There was a problem hiding this comment.
Addressed in 3cfa545.
| def __call__(self, *args, **kwargs): | ||
| raise elasticsearch.TransportError | ||
|
|
||
| raiseTransportError = TransportErrorSupplier() |
There was a problem hiding this comment.
Addressed in 3cfa545.
| def __call__(self, *args, **kwargs): | ||
| raise elasticsearch.TransportError | ||
|
|
||
| raiseTransportError = TransportErrorSupplier() | ||
|
|
||
| class TransportClient: |
There was a problem hiding this comment.
Addressed in 3cfa545.
|
@dliappis thanks for the initial pass. I've addressed your comments. Can you please have another look? |
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Aug 12, 2019
With this commit we make Rally more resilient when it is not able to determine some information upon startup of the cluster. Relates elastic#730
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Aug 12, 2019
With this commit we make Rally more resilient when it is not able to determine some information upon startup of the cluster. Relates elastic#730
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Aug 12, 2019
With this commit we make Rally more resilient when it is not able to determine some information upon startup of the cluster. Relates elastic#730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we make Rally more resilient when it is not able to
determine some information upon startup of the cluster.