Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lap feature and all references. #739

Merged
merged 11 commits into from
Aug 14, 2019
Merged

Conversation

drawlerr
Copy link
Contributor

@drawlerr drawlerr commented Aug 8, 2019

This feature complicates development and can be done with user tags, so is unnecessary.

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! I left a few comments but nothing substantial. Apart from that it's already looking pretty good. I found an additional leftover in

LAP_SCORE = r"""
Can you please remove this one as well?

When raising a PR we should also always set labels and the corresponding milestone. Can you please also do that here (and in future PRs when raising them)?

docs/command_line_reference.rst Show resolved Hide resolved
esrally/metrics.py Outdated Show resolved Hide resolved
esrally/reporter.py Outdated Show resolved Hide resolved
esrally/reporter.py Show resolved Hide resolved
@drawlerr drawlerr added this to the 1.3.0 milestone Aug 9, 2019
@drawlerr drawlerr added the breaking Non-backwards compatible change label Aug 9, 2019
@danielmitterdorfer danielmitterdorfer added :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Metrics How metrics are stored, calculated or aggregated :Reporting Command line reporting enhancement Improves the status quo labels Aug 12, 2019
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few asks about the docs but the rest of this change looks fine. I've also applied more labels now. For future reference: We require the following labels on all PRs:

  1. Type of change, see the release notes script for details
  2. Indication whether this is a breaking change
  3. One or more area labels (these start with a colon)

docs/migrate.rst Outdated Show resolved Hide resolved
docs/migrate.rst Outdated Show resolved Hide resolved
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating. One final bit and we're there. :)

docs/migrate.rst Outdated
@@ -10,18 +10,15 @@ This means that on disk, a given race will be found at ``benchmarks/races/62d1e9

Laps feature removed
^^^^^^^^^^^^^^^^^^^^
The --laps parameter and corresponding multi-run trial functionality has been removed from execution and reporting.
If you need lap functionality, the following shell script can be used instead:
The ```--laps``` parameter and corresponding multi-run trial functionality has been removed from execution and reporting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be enclosed in double-backticks, not triple-backticks.

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! LGTM :)

@drawlerr drawlerr merged commit 2f4b844 into elastic:master Aug 14, 2019
@drawlerr drawlerr deleted the remove-laps branch August 14, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Metrics How metrics are stored, calculated or aggregated :Reporting Command line reporting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants