Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather cluster-level metrics in driver #779

Merged
merged 11 commits into from
Oct 2, 2019

Conversation

danielmitterdorfer
Copy link
Member

@danielmitterdorfer danielmitterdorfer commented Sep 30, 2019

With this commit we gather cluster-level metrics in the driver instead of the
mechanic. As these metrics are gathered via API calls there is no need to gather
them on the very same machine were an Elasticsearch node is running. Instead, it
defines clearer boundaries in between these two components.

Relates #697

@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated breaking Non-backwards compatible change labels Sep 30, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.4.0 milestone Sep 30, 2019
@danielmitterdorfer danielmitterdorfer changed the title Race metadata Gather cluster-level metrics in driver Sep 30, 2019
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bold new era! LGTM, I left minor comments that can be addressed without a need for another review cycle.

docs/migrate.rst Outdated Show resolved Hide resolved
esrally/driver/driver.py Show resolved Hide resolved
esrally/driver/driver.py Outdated Show resolved Hide resolved
esrally/mechanic/mechanic.py Outdated Show resolved Hide resolved
@danielmitterdorfer danielmitterdorfer merged commit 52d9c33 into elastic:master Oct 2, 2019
@danielmitterdorfer danielmitterdorfer deleted the race-metadata branch October 2, 2019 10:50
novosibman pushed a commit to novosibman/rally that referenced this pull request Oct 2, 2019
With this commit we gather cluster-level metrics in the driver instead of the
mechanic. As these metrics are gathered via API calls there is no need to gather
them on the very same machine were an Elasticsearch node is running. Instead, it
defines clearer boundaries in between these two components.

Relates elastic#697
Relates elastic#779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants