-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gather cluster-level metrics in driver #779
Merged
danielmitterdorfer
merged 11 commits into
elastic:master
from
danielmitterdorfer:race-metadata
Oct 2, 2019
Merged
Gather cluster-level metrics in driver #779
danielmitterdorfer
merged 11 commits into
elastic:master
from
danielmitterdorfer:race-metadata
Oct 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmitterdorfer
added
enhancement
Improves the status quo
:Metrics
How metrics are stored, calculated or aggregated
breaking
Non-backwards compatible change
labels
Sep 30, 2019
danielmitterdorfer
changed the title
Race metadata
Gather cluster-level metrics in driver
Sep 30, 2019
dliappis
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bold new era! LGTM, I left minor comments that can be addressed without a need for another review cycle.
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
With this commit we gather cluster-level metrics in the driver instead of the mechanic. As these metrics are gathered via API calls there is no need to gather them on the very same machine were an Elasticsearch node is running. Instead, it defines clearer boundaries in between these two components. Relates elastic#697 Relates elastic#779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Non-backwards compatible change
enhancement
Improves the status quo
:Metrics
How metrics are stored, calculated or aggregated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we gather cluster-level metrics in the driver instead of the
mechanic. As these metrics are gathered via API calls there is no need to gather
them on the very same machine were an Elasticsearch node is running. Instead, it
defines clearer boundaries in between these two components.
Relates #697