Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage dev dependencies in setup.py #788

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we define development dependencies as extra
requirements and set them up in the make install target. This
simplifies setup and also removes duplication from our tox
configuration.

Closes #439

With this commit we define development dependencies as extra
requirements and set them up in the `make install` target. This
simplifies setup and also removes duplication from our tox
configuration.

Closes elastic#439
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Oct 9, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.4.0 milestone Oct 9, 2019
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielmitterdorfer danielmitterdorfer merged commit ddfca71 into elastic:master Oct 10, 2019
@danielmitterdorfer danielmitterdorfer deleted the install-dev-in-setup-py branch October 10, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage development dependencies in setup.py
2 participants