Allow to show track details #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we introduce a new `info` subcommand to Rally that allows users to print details about a track on the command line. This can be useful to see which challenges exist and which tasks are executed in each of them.
danielmitterdorfer
added
enhancement
Merged
ebadyano
reviewed
Dec 19, 2019
| @@ -202,6 +202,35 @@ The new track appears when you run ``esrally list tracks --track-path=~/rally-tr | |||
| ---------- ----------------------------- ----------- --------------- ----------------- | |||
| tutorial Tutorial benchmark for Rally 11658903 N/A 1.4 GB | |||
|
|
|||
| You can also show details about your track with ``esrally info --track-path=~/rally-tracks/tutorial``:: | |||
|
|
|||
| dm@io:~ $ esrally info --track-path=~/rally-tracks/tutorial | |||
There was a problem hiding this comment.
should we remove dm@io $ portion?
There was a problem hiding this comment.
This was kind of intentional to make it clear that this is a prompt.
|
Very cool feature, thank you! Do you think we want to add any tests? The feature itself is kind of like for testing, but maybe we want to add some to make sure some changes in the future don't break it? |
Thanks for the review. As discussed on another channel, let's add some integration tests for starters. |
|
Thanks for the review! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we introduce a new
infosubcommand to Rally thatallows users to print details about a track on the command line. This
can be useful to see which challenges exist and which tasks are executed
in each of them.