Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the venv pylint in the makefile #858

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Jan 9, 2020

The makefile assumes a activated venv or a global pylint and the CI
machines have neither of these. I took the same approach we use for
python3 itself within the makefile.

The makefile assumes a activated venv or a global pylint and the CI
machines have neither of these. I took the same approach we use for
python3 itself within the makefile.
@hub-cap hub-cap added bug Something's wrong :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jan 9, 2020
Copy link
Contributor

@drawlerr drawlerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hub-cap hub-cap merged commit 8c59b39 into elastic:master Jan 9, 2020
@hub-cap hub-cap deleted the fix_lint_makefile branch January 9, 2020 21:48
@danielmitterdorfer danielmitterdorfer added this to the 1.4.0 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants