Detach Elasticsearch on startup #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we detach Elasticsearch on startup from its controlling process via the [setpgrp](http://man7.org/linux/man-pages/man3/setpgrp.3p.html) system call. Although we start Elasticsearch with the `-d` flag, this is necessary to ensure it does not receive signals like `SIGHUP` from its original parent process (Rally).
danielmitterdorfer
added
bug
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
Jan 29, 2020
With this commit we use the parameter `start_new_session` to detach Elasticsearch from its parent process group (Rally) instead of the problematic (and low-level) `preexec_fn`. Under the hood this will use the `setsid` system call instead of `setpgrp`. See also: * https://linux.die.net/man/2/setsid * https://linux.die.net/man/2/setpgrp Relates elastic#859
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 30, 2020
With this commit we use the parameter `start_new_session` to detach Elasticsearch from its parent process group (Rally) instead of the problematic (and low-level) `preexec_fn`. Under the hood this will use the `setsid` system call instead of `setpgrp`. See also: * https://linux.die.net/man/2/setsid * https://linux.die.net/man/2/setpgrp Relates #859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we detach Elasticsearch on startup from its controlling
process via the setpgrp system call. Although we start Elasticsearch
with the
-dflag, this is necessary to ensure it does not receive signalslike
SIGHUPfrom its original parent process (Rally).