Store system metrics if race metadata are present #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we avoid interacting in any way with the metrics store if we could not retrieve any race metadata. This situation can happen when we have never started a benchmark, the provided race id does not match or we use an in-memory metrics store instead of Elasticsearch. In all these cases we cleanly shutdown the node instead of raising errors.
danielmitterdorfer
added
bug
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we avoid interacting in any way with the metrics store
if we could not retrieve any race metadata. This situation can happen
when we have never started a benchmark, the provided race id does not
match or we use an in-memory metrics store instead of Elasticsearch. In
all these cases we cleanly shutdown the node instead of raising errors.
Relates #860
Relates #830