Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition with old ES processes in IT tests #886

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

dliappis
Copy link
Contributor

Occasionally IT tests fail in a very subtle way when Rally spins up ES
shortly after a previous test: while the previous ES process gets
killed, the socket lingers and when Rally spins up the new ES process
for the test, ES detects the used port and binds itself to the
next one (e.g. 39201, for the HTTP API).

Wait until the socket used by ES HTTP API is really closed.

Occasionally IT tests fail in a very subtle way when Rally spins up ES
shortly after a previous test: while the previous ES process gets
killed, the socket lingers and when Rally spins up the new ES process
for the test, ES detects the used port and binds itself to the
next one (e.g. 39201, for the HTTP API).

Wait until the socket used by ES HTTP API is really closed.
@dliappis dliappis added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jan 31, 2020
@dliappis dliappis added this to the 1.4.1 milestone Jan 31, 2020
@dliappis dliappis self-assigned this Jan 31, 2020
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@dliappis dliappis merged commit 949107e into elastic:master Jan 31, 2020
@dliappis dliappis deleted the wait-until-port-is-closed-for-it branch January 31, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants