Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom probing URL #909

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Add custom probing URL #909

merged 2 commits into from
Feb 19, 2020

Conversation

bartier
Copy link
Contributor

@bartier bartier commented Feb 19, 2020

It makes the probing URL configurable via rally.ini instead of always using https://github.com/ as probing URL.

Closes #866

@bartier bartier mentioned this pull request Feb 19, 2020
Closed
danielmitterdorfer
danielmitterdorfer reviewed Feb 19, 2020
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @bartier! I left two small suggestions but apart from that the change looks good. Can you please have a look?

docs/offline.rst Outdated Show resolved Hide resolved
docs/offline.rst Outdated Show resolved Hide resolved
@danielmitterdorfer
Copy link
Member

@elasticmachine test this please

@danielmitterdorfer danielmitterdorfer added :Usability Makes Rally easier to use enhancement Improves the status quo labels Feb 19, 2020
@danielmitterdorfer
Copy link
Member

@elasticmachine test this please

danielmitterdorfer
danielmitterdorfer approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating! Looks good to me. If all goes well (CI build is still pending) then this will be released with Rally 1.4.1.

@danielmitterdorfer danielmitterdorfer added this to the 1.4.1 milestone Feb 19, 2020
@danielmitterdorfer danielmitterdorfer merged commit 1fcf3a7 into elastic:master Feb 19, 2020
@danielmitterdorfer
Copy link
Member

cla/check

@bartier bartier mentioned this pull request Feb 19, 2020
Open
@danielmitterdorfer danielmitterdorfer mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

Private custom track repository and corpora URLs
2 participants
@bartier @danielmitterdorfer