Gather system metrics on Docker stop if possible #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we check whether the stop subcommand could determine details about the current race and only attempt to store system metrics if this is the case. If Docker is used with an in-memory metrics store for example we have no means of retrieving the race and in this case we need to avoid storing anything.
danielmitterdorfer
added
bug
|
@elasticmachine test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we check whether the stop subcommand could determine
details about the current race and only attempt to store system metrics
if this is the case. If Docker is used with an in-memory metrics store
for example we have no means of retrieving the race and in this case we
need to avoid storing anything.